Review 11.5 Merged

75813[BUGFIX] Don't ignore TCA 'ctrl' 'groupName'

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 09/21/22, 13:00

Commit message

The new records controller (list modul "+" button) tries
to group records. TCA 'ctrl' property 'groupName'
can be used to hint this grouping.

Current code overrides TCA groupName with split magic
based on table name, though. The patch fixes this.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Falk Gebauer +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Falk Gebauer +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Christian Kuhn commented on patch set 1 09/21/22, 12:48

    Cherry Picked from branch main.
  2. Falk Gebauer commented on patch set 1 V +1 CR +1 09/21/22, 12:56

    Looks good here!
  3. core-ci voted on patch set 1 V +1 09/21/22, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31365

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 09/21/22, 13:00

  5. Christian Kuhn merged patch set 2 09/21/22, 13:00

  6. Christian Kuhn commented on patch set 2 09/21/22, 13:00

    thx for additional vote, Falk!