Review main Merged

75836[TASK] Improve usability of logicalAnd and logicalOr

Markus Klein CR +2 V +2 Normal +54 −108 updated 10/01/22, 12:41

Commit message

Due to the improved strictness of the API the query
methods logicalAnd and logicalOr required at least
two parameters.

This is very inconvenient for developers and force
the same boilerplate code to be present in almost
all extensions using array decomposition like:
->logicalAnd(...$constraints)

Prevent this situation by adding dummy-conditions
inside the methods to fulfill the interface's contracts.

As it is impossible to add straight conditions like
"1=1" directly from within the Query object, the
solution is to use conditions based on the "uid" field.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 8