Review main Merged

75840[BUGFIX] Improve performance of "View Upgrade Documentation"

Andreas Kienast CR +2 V +2 Normal +49 −64 updated 09/22/22, 12:53

Commit message

This patch greatly improves the performance of the
"View Upgrade Documentation" module in the Install Tool.

The following optimizations are done:

* The tag filter is initialized only once now to avoid double-filtering
  documents
* Document tags are now rendered directly in Fluid, removing one
  expensive document manipulation task
* Composition of the tag list for the tag filter is sped up by a factor
  of 1.5 - 2 by using Set() to filter most duplicates
* When emptying a search, internal upgrade doc classes are removed once
  all panels are hidden
* When filtering, matching version panels are expanded with a delay of
  20ms, relaxing re-layouts and repaints in the browser

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4