Review main Merged

75848[BUGFIX] Fix glitches in controls of EXT:viewpage

Andreas Kienast CR +2 V +2 Easy +8 −6 updated 09/23/22, 14:53

Commit message

The controls of EXT:viewpage have several glitches which are fixed in
this patch:

* The label of the "Custom" preset is added again on initial load
* Setting a custom width now properly updates the selector in the preset
  dropdown
* Updating the custom size also stores the data in the "current" scope
* The controls now adapt to the dark appearance of the backend module

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1115

  1. Andreas Kienast uploaded patch set 1 09/22/22, 11:58

  2. core-ci voted on patch set 1 V +1 09/22/22, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31432

  3. Andreas Kienast uploaded patch set 2 09/22/22, 12:21

  4. core-ci voted on patch set 2 V +1 09/22/22, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31436

  5. Guido Schmechel commented on patch set 2 09/22/22, 13:32

    ViewModuleController.php:109

    I know you didn't change the post, but $custom['custom'] sounds weird. Shouldn't it rather be $custom['height']?
  6. Andreas Kienast commented on patch set 2 09/22/22, 13:37

    ViewModuleController.php:109 Reply

    Ack
  7. Andreas Kienast uploaded patch set 3 09/22/22, 13:38

  8. Susi Moog voted on patch set 3 V +1 09/22/22, 13:43

  9. core-ci voted on patch set 3 V +1 09/22/22, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31450

  10. Benni Mack voted on patch set 3 CR +1 09/22/22, 14:08

  11. Andreas Kienast uploaded patch set 4 09/23/22, 14:28

  12. core-ci voted on patch set 4 V +1 09/23/22, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31479

  13. Oli Bartsch voted on patch set 4 V +1 CR +1 09/23/22, 14:50

  14. Andreas Kienast voted on patch set 4 V +2 CR +2 09/23/22, 14:53

  15. Andreas Kienast merged patch set 5 09/23/22, 14:53