Review main Merged

75852[BUGFIX] Prevent undefined array key in TimeTracker

Daniel Siepmann CR +2 V +2 Easy +6 −4 updated 09/29/22, 14:06

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Daniel Siepmann uploaded patch set 1 09/22/22, 13:09

  2. core-ci voted on patch set 1 V +1 09/22/22, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31445

  3. Oliver Klee commented on patch set 1 09/22/22, 13:32

    TimeTracker.php:385

    We have this construct now twice each for ownTime and stackPointer. I propose moving this to two local variables $stackPointer and $ownTime to get rid of the duplication.
  4. Frank Nägler uploaded patch set 2 09/29/22, 13:16

  5. Frank Nägler commented on patch set 2 09/29/22, 13:16

    I pushed an update that introduce the variables.

    TimeTracker.php:385 Reply

    Ack
  6. core-ci voted on patch set 2 V +1 09/29/22, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31708

  7. Oliver Klee voted on patch set 2 CR +1 09/29/22, 13:37

  8. Simon Schaufelberger voted on patch set 2 V +1 CR +1 09/29/22, 13:55

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 09/29/22, 14:06

  10. Christian Kuhn merged patch set 3 09/29/22, 14:06