Review main Merged

75860[FEATURE] Introduce AfterRecordSummaryForLocalizationEvent

Achim Fritz CR +2 V +2 Normal +125 −3 updated 09/27/22, 20:21

Commit message

this adds a new PSR-14 Event into the LocalizationController
allowing extension authors to modify the whole payload in the
JsonResponse of the getRecordLocalizeSummary Method

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1217

  1. Achim Fritz uploaded patch set 1 09/23/22, 10:26

  2. core-ci voted on patch set 1 V +1 09/23/22, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31475

  3. Guido Schmechel commented on patch set 1 09/23/22, 12:19

  4. Achim Fritz uploaded patch set 2 09/27/22, 12:01

  5. Benni Mack commented on patch set 3 09/27/22, 12:03

    Published edit on patch set 2.
  6. Benni Mack commented on patch set 3 CR -1 09/27/22, 12:05

    composer.json:50

    this seems wrong :)
  7. Achim Fritz uploaded patch set 4 09/27/22, 12:08

  8. core-ci voted on patch set 2 V +1 09/27/22, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31583

  9. core-ci voted on patch set 3 V +1 09/27/22, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31584

  10. core-ci voted on patch set 4 V +1 09/27/22, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31585

  11. Benni Mack commented on patch set 5 09/27/22, 12:17

    Published edit on patch set 4.
  12. Benni Mack commented on patch set 5 CR +1 09/27/22, 12:17

    composer.json:50 Reply

    Done
  13. core-ci voted on patch set 5 V +1 09/27/22, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31587

  14. Georg Ringer voted on patch set 5 V +1 CR +1 09/27/22, 19:05

  15. Guido Schmechel commented on patch set 5 CR +1 09/27/22, 19:59

    Thanks for your detailed documentation! :-)
  16. Benni Mack voted on patch set 5 V +2 CR +2 09/27/22, 20:21

  17. Benni Mack merged patch set 6 09/27/22, 20:21