Review main Merged Breaking

75861[!!!][TASK] Remove workspace tsconfig swapMode and changeStageMode

Christian Kuhn CR +2 V +2 Hard +63 −483 updated 09/26/22, 14:44

Commit message

EXT:workspace User TSconfig options "options.workspaces.swapMode"
and "options.workspaces.changeStageMode":

* They are at least partially broken since the switch to
  doctrine/dbal in core v8. This hasn't been reported as
  bug, we can safely assume they are used very seldom.
* They are rather hard to understand and usability wise
  questionable since more elements than selected in the Backend
  module magically change workspace state or are published.
* The options are at least partially obsolete since the
  core considers references for important child records
  internally already - for instance for inline parent-child
  relations - and changes child state as needed.

The patch removes these TSconfig options and their
implementation.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 5