Review main Merged Breaking

75864[!!!][FEATURE] Use Routing for getQueryArguments / addQueryString

Benni Mack CR +2 V +2 Hard +257 −66 updated 10/03/22, 10:33

Commit message

With Typolink (and the typolink ViewHelpers), a new option is
now available to allow to add ALL current queryParameters
to the created URL when creating frontend links.

10 = TEXT
10.typolink.parameter = 12
10.typolink.addQueryString = untrusted

addQueryString now allows to be set to "0" (do not do anything),
or "1"/"true" or "untrusted" (new) which then makes it possible
to add only "safe" query parameters which have been matched
during the routing process.

The breaking change here is that "addQueryString = 1" does
- by default - only include the mapped query arguments from
the Page Routing, avoiding unneeded GET parameters to be
added by default.

The affected method has been moved from ContentObjectRenderer
to PageLinkBuilder now.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 13