Review 11.5 Merged

75878[BUGFIX] Always send strings to the method createStream

Michael Voehringer CR +2 V +2 Easy +2 −2 updated 10/21/22, 07:23

Commit message

PHP8.1 throws an TypeError if we sending null to createStream

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. Michael Voehringer uploaded patch set 1 09/27/22, 12:28

  2. core-ci voted on patch set 1 V +1 09/27/22, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31588

  3. Oliver Klee voted on patch set 1 CR +1 09/27/22, 13:10

  4. Stefan Bürk commented on patch set 1 CR -1 10/03/22, 20:29

    First, should be done on main and than backported. So creating a forwart first would be nice. Also "releases" should be added. Codewise this should be also the same issue in main/v12. (Also not tested). I'm more curios -- if $html is null, $this->view->render() should return a string ... so this *should* not be an issue at all ...
  5. Michael Voehringer commented on patch set 1 10/04/22, 08:00

    Reply

    Thank you for you review. This is a bug only in the v11 branch. In v12 the ViewInterface changed and only allow strings as return value. So this is not a problem in v12. In v11 also other types (like null) are possible. 11.x interface ViewInterface { .. /** * Renders the view * * @return string The rendered view */ public function render(); main: interface ViewInterface { .. /** * Renders the view. Optionally receives a template location. */ public function render(string $templateFileName = ''): string;
  6. Stefan Bürk commented on patch set 1 10/13/22, 14:06

    Reply

    That's not fully correct. There are "multiple" interfaces. Fluid Package ViewInterface, ext:extbase ViewInterface and ext:core ViewInterface. First two have only return string as "docblock" not as typehint, so may be null. The new ext:core interface has it and backend modules uses this interface. So no, it is not ensured in v12. My points are thus still valid. Upport (main) + adding release addition.
  7. Stefan Bürk updated the commit message in patch set 2 10/20/22, 18:48

  8. Stefan Bürk commented on patch set 2 10/20/22, 18:56

    Reply

    Cherry-picked to main, voting should be done there. Keeping this 11.5 as prepared backport.
  9. core-ci voted on patch set 2 V +1 10/20/22, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32527

  10. Anja Leichsenring uploaded patch set 3 10/21/22, 07:14

  11. Anja Leichsenring commented on patch set 3 10/21/22, 07:15

    all right, merged the main patch, cherry-picked it here, but no change to PS2. Will merge after CI says yes.
  12. Oliver Klee voted on patch set 3 CR +1 10/21/22, 07:18

  13. core-ci voted on patch set 3 V +1 10/21/22, 07:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32559

  14. Anja Leichsenring voted on patch set 3 V +2 CR +2 10/21/22, 07:23

  15. Anja Leichsenring merged patch set 4 10/21/22, 07:23