75880[BUGFIX] Generate correct asset symlinks on Windows
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 912
-
Robert Kärner uploaded patch set 1 09/27/22, 13:00
-
core-ci voted on patch set 1 V +1 09/27/22, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31591
-
Nicole Hummel uploaded patch set 2
V +101/06/23, 11:31 -
Nicole Hummel voted on patch set 2 V +1 CR +1 01/06/23, 11:32
-
Robert Kärner commented on patch set 2 01/06/23, 11:37
Thank you for the update, Nicole! Just wanted to note that I tackled the assets publishing as junctions in patch #75867. Should we move your changes to the other patch or just close the other one? -
Robert Kärner commented on patch set 2 01/06/23, 11:38
Reply
Sorry, the correct link is: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75867 -
core-ci voted on patch set 2 V +1 01/06/23, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35530
-
Nicole Hummel uploaded patch set 3
CR +1V +101/06/23, 12:06 -
Nicole Hummel commented on patch set 3 V +1 CR +1 01/06/23, 12:09
Reply
Seems like I haven't found the other issue in the tracker. I would love to handle both Windows fixes in one ticket. This ensures ones this ticket is merged, an installation on Windows system can finally work and is doesn't depend on further handling.PackageArtifactBuilder.php:172I recommend to replace backslashes even on Unix systems as the core itself replaces them for all (package) paths by default. -
core-ci voted on patch set 3 V +1 01/06/23, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35533
-
Robert Kärner commented on patch set 3 01/06/23, 15:09
Reply
Fine with me. Let's continue in the other issue then, as it got more attention and includes the thoughts and discussion with Stefan and me.PackageArtifactBuilder.php:172Reply UnresolvedAlso fine for me. I will add this and the whole changes of this patch to https://review.typo3.org/c/Packages/TYPO3.CMS/+/75867 after the weekend. You can do as well, if you find some time before. Will abandon this patch afterwards. -
Robert Kärner abandoned the change 01/17/23, 06:43
This will be solved by https://review.typo3.org/c/Packages/TYPO3.CMS/+/75867 instead.