Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
75924[!!!][TASK] Hash package version into public resource paths
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 3
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/24/75924/3 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/24/75924/3 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -2 Blocked
- Benjamin Franzke -2
- Helmut Hummel +1
-
Verified V -1 Blocked
- Helmut Hummel -1
- core-ci +1 CI
Issues 2
Files 2
Review log 1316
-
Benjamin Franzke uploaded patch set 1 09/30/22, 12:58
-
Benni Mack commented on patch set 1 09/30/22, 13:04
could we combine this patch with https://review.typo3.org/c/Packages/TYPO3.CMS/+/75384 ? -
Stefan Bürk commented on patch set 1 09/30/22, 13:10
Not tested, but wondering - would that not mean that old symlinks will stay if a package is updated ? eventually broken if it is not there anymore in the new version ? eventually doing a "public/_assets/<extension-key[hash]/<version-symlink-hash> ? -
core-ci voted on patch set 1 V -1 09/30/22, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31752
-
Benjamin Franzke commented on patch set 1 09/30/22, 13:17
Reply Unresolved
well, hm, this patch is quite the opposite. I think we'd rather adapt that patch to make it an explicit composer.json configuration to use a preset-qualifier as asset path (disabling optimizations for importmaps/versionNumbering). I mean: We don't want people to hardocde paths, but still there are usecases where an extension needs to be able to provide static-assets: e-mail marketing/links So my take would be: use an explicit configuration for static paths.Reply Unresolved
They would stay: yes Broken: no You could end up with many stale ones, yes. Example: ls public/_assets/ -l | grep backend lrwxrwxrwx 1 ben ben 47 30. Sep 14:17 081fa96a07de1dccb64a8a83e1567439 -> ../../vendor/typo3/cms-backend/Resources/Public lrwxrwxrwx 1 ben ben 47 30. Sep 09:53 a612e037c0219f0e06b849aeb374c166 -> ../../vendor/typo3/cms-backend/Resources/Public -
Benjamin Franzke uploaded patch set 2 09/30/22, 13:19
-
core-ci voted on patch set 2 V +1 09/30/22, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31757
-
Chris Müller commented on patch set 2 09/30/22, 13:46
Breaking-98481-HashPackageVersionIntoPublicResourcePaths.rst:26benifit -> benefit -
Benjamin Franzke uploaded patch set 3 09/30/22, 14:08
-
Benjamin Franzke commented on patch set 3 09/30/22, 14:08
Breaking-98481-HashPackageVersionIntoPublicResourcePaths.rst:26ReplyDone -
Helmut Hummel voted on patch set 3 V +1 CR +1 09/30/22, 14:12
-
Helmut Hummel commented on patch set 3 V -1 09/30/22, 14:13
Ah, wait. The URL generation needs to be adapted as well then -
core-ci voted on patch set 3 V +1 09/30/22, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31759
-
Benjamin Franzke commented on patch set 3 09/30/22, 14:42
Reply Unresolved
oops, sorry… I though that'd already use the installed-versions-api. Problably makes sense to merge and test that with https://review.typo3.org/c/Packages/TYPO3.CMS/+/75384 then, in order to provide both usecases directly. -
Benjamin Franzke commented on patch set 3 CR -2 10/01/22, 15:56
Needs to be postponed for possible security reasons for now (information disclosure regarding extension version numbers). -
Benjamin Franzke marked it work in progress 10/01/22, 15:56