Review main Merged

75942[BUGFIX] Avoid possible notice in AbstractPlugin

Georg Ringer CR +2 V +2 Easy +2 −2 updated 10/03/22, 17:46

Commit message

Checking for a not existing value of a flexform sheet must not lead
to a notice.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Kevin Appelt +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Kevin Appelt +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1214

  1. Georg Ringer uploaded patch set 1 10/02/22, 18:44

  2. Georg Ringer commented on patch set 1 10/02/22, 18:45

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 10/02/22, 18:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31906

  4. Oliver Klee commented on patch set 2 10/02/22, 19:45

    Published edit on patch set 1.
  5. core-ci voted on patch set 2 V +1 10/02/22, 19:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31912

  6. Oliver Klee voted on patch set 2 CR +1 10/02/22, 20:16

  7. Ralph Brugger commented on patch set 2 10/03/22, 10:11

    After relpacing only this file, I'm getting : Fatal error: Type of DirectMailTeam\DirectMail\Plugin\DirectMail::$cObj must be ?TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer (as in class TYPO3\CMS\Frontend\Plugin\AbstractPlugin) in typo3conf/ext/direct_mail/Classes/Plugin/DirectMail.php on line 0
  8. Christian Kuhn commented on patch set 2 10/03/22, 14:06

    Reply

    sounds fishy. to test patches, it's in general better to follow https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/ i assume you're running into a local problem here, maybe something with access rights? if you continue to have issues with this feel free to contact the core team via slack.
  9. Christian Kuhn voted on patch set 2 V +1 CR +1 10/03/22, 14:08

  10. Kevin Appelt voted on patch set 2 V +1 CR +1 10/03/22, 14:25

  11. Nikita Hovratov voted on patch set 2 V +1 CR +1 10/03/22, 16:24

  12. Stefan Bürk voted on patch set 2 V +1 CR +1 10/03/22, 16:53

  13. Georg Ringer voted on patch set 2 V +2 CR +2 10/03/22, 17:46

  14. Georg Ringer merged patch set 3 10/03/22, 17:46