Review 11.5 Merged

75946[TASK] Mitigate browser "spell jacking" in form elements

Oliver Hader CR +2 V +2 Easy +21 −18 updated 10/04/22, 17:02

Commit message

Having manually(!) enabled "enhanced spell checking" in browsers,
can lead to scenarios where password data is sent to remote services
which actually take care of the spell checking.

see https://www.otto-js.com/news/article/chrome-and-edge-enhanced-spellcheck-features-expose-pii-even-your-passwords

Since this issue is caused by browsers and the determination of
"confidentiality" is fuzzy here, this issue is handled in public.

Following changes have been applied:
+ forms dealing mainly with credentials, as well as all forms in
  ext:install  have been adjusted to `<form ... spellcheck="false">`
+ other password form elements, including TCA type `password` have
  been adjusted to `<input type="password" ... spellcheck="false">`

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 16