Review main Merged

75951[TASK] Improve type annotations for ExpressionBuilder::literal()

Oliver Klee CR +2 V +2 Easy +1 −1 updated 10/19/22, 11:58

Commit message

PHPStan will (correctly) unify the previous type
`\PDO::PARAM_*|Connection::PARAM_*|int` to `int` (because
`\PDO::PARAM_*` as well as `Connection::PARAM_*` are all
ints).

So we're using the stricter `Connection::PARAM_*` now, which is a
superset of `\PDO::PARAM_*`.

This allows PHPStan to catch calls to this method with
incorrect values.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1