75996[BUGFIX] Prevent undefined array index "pi_flexform"
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Josef Glatz +1
- Oliver Klee +1
-
Verified V +2 Done
- Christian Kuhn +2
- Josef Glatz +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1518
-
Simon Schaufelberger uploaded patch set 1 10/05/22, 13:44
-
core-ci voted on patch set 1 V +1 10/05/22, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32039
-
Oliver Klee commented on patch set 1 10/05/22, 14:21
-
Simon Schaufelberger uploaded patch set 2 10/05/22, 14:42
-
Simon Schaufelberger commented on patch set 2 10/05/22, 14:43
AbstractPlugin.php:1307Replylike this? -
core-ci voted on patch set 2 V +1 10/05/22, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32043
-
Oliver Klee commented on patch set 2 CR +1 10/05/22, 14:51
AbstractPlugin.php:1307ReplyYes, exactly. Beautiful! -
Simon Schaufelberger commented on patch set 2 10/05/22, 15:10
AbstractPlugin.php:1307ReplyDone -
Oliver Klee commented on patch set 2 CR 0 10/05/22, 19:29
AbstractPlugin.php:1308I've just noticed: We also need to cast $fieldData to a string for the xml2array call. -
Simon Schaufelberger commented on patch set 2 10/06/22, 00:21
AbstractPlugin.php:1308Replyshouldn't this be always a string? well, I will do that later. -
Simon Schaufelberger uploaded patch set 3 10/06/22, 08:51
-
Simon Schaufelberger commented on patch set 3 10/06/22, 08:51
AbstractPlugin.php:1308ReplyDone -
core-ci voted on patch set 3 V +1 10/06/22, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32055
-
Oliver Klee voted on patch set 3 CR +1 10/06/22, 09:20
-
Christian Kuhn voted on patch set 3 V +1 CR +1 10/10/22, 22:29
-
Josef Glatz commented on patch set 3 V +1 CR +1 10/11/22, 03:53
great, thx for the patch. had also such scenario -
Christian Kuhn voted on patch set 3 V +2 CR +2 10/11/22, 04:16
-
Christian Kuhn merged patch set 4 10/11/22, 04:16
AbstractPlugin.php:1307