Review main Merged

75998[TASK] Update to PHPStan 1.8.8

Oliver Klee CR +2 V +2 Normal +21 −31 updated 10/06/22, 18:26

Commit message

This update finds new problems and gets rid of some
false positives.

Run commands:

> composer req --dev phpstan/phpstan:^1.8.8
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 45

  1. Oliver Klee uploaded patch set 1 10/06/22, 14:37

  2. core-ci voted on patch set 1 V +1 10/06/22, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32056

  3. Benni Mack voted on patch set 1 V +1 CR +1 10/06/22, 15:14

  4. Georg Ringer voted on patch set 1 V +2 CR +2 10/06/22, 18:26

  5. Georg Ringer merged patch set 2 10/06/22, 18:26