Review main Merged

76004[BUGFIX] Avoid undefined array key access in PageInfoViewHelper

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 10/08/22, 12:41

Commit message

Use guard to avoid undefined array key acces in core viewhelper
`\TYPO3\CMS\Fluid\ViewHelpers\Be\PageInfoViewHelper`.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Stefan Bürk uploaded patch set 1 10/08/22, 00:25

  2. core-ci voted on patch set 1 V +1 10/08/22, 00:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32090

  3. Oliver Klee voted on patch set 1 CR +1 10/08/22, 07:50

  4. Simon Schaufelberger commented on patch set 1 10/08/22, 10:35

    no markdown support here. sorry.
  5. Stefan Bürk commented on patch set 1 10/08/22, 10:54

    Reply

    It's not about markdown, it's about marking it. Not the first time this is used around namespaces/class names in commit messages. No rule against it. So this is fine.
  6. Simon Schaufelberger voted on patch set 1 V +1 CR +1 10/08/22, 11:19

  7. Christian Kuhn voted on patch set 1 V +1 CR +1 10/08/22, 12:36

  8. Stefan Bürk voted on patch set 1 V +2 CR +2 10/08/22, 12:41

  9. Stefan Bürk merged patch set 2 10/08/22, 12:41