Review main Merged

76006[BUGFIX] Ensure proper error_reporting reset in JwtTrait workaround

Stefan Bürk CR +2 V +2 Easy +16 −8 updated 10/08/22, 15:42

Commit message

With the introduction of CSRF-like request tokens in #97305 a
3rd party dependency has been added with a PHP8.2 deprecation.
To mitigate this, a workaround has been added to set and reset
the error level in the implementation in JwtTrait.

However, if the called methods throw exception on invalid tokens
the reset has been left out, leaving the `error_reporting` in a
changed state and thus changing the system.

This can be verified using:

> Build/Scripts/runTests.sh -s unitRandom -p 8.2 -o 1665191152

This change wraps the method calls in try-catch blocks and
ensure the error_reporting is properly reset before re-throw
the exception to keep the exception handling workflow intact.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1