Review 11.5 Merged

76011[TASK] Extend testing range to PHP8.2 with more dbms versions

Stefan Bürk CR +2 V +2 Hard +391 −63 updated 12/01/22, 11:25

Commit message

doctrine/dbal 2.x version has reached EOL, which means that
there will be no new version in this version range. Sadly,
doctrine/dbal triggers a deprecation warning in PHP8.2 which
will not be fixed upstream.

Raising that dependency is out of the scope for TYPO3 v11. This
issue is mitigated by adding the well-known composer dependency
`cweagans/composer-patches` as dev dependency. Additionally, a
corresponding composer patch targeting the PHP8.2 variable
interpolation deprecation warning is applied in CI for testing
purpose.

UpgradeCest acceptance tests is adjusted to execute some steps
only for appropriate dbms/drivers, as they are not targeting the
newer versions.

This change:
* Adds composer patcher `cweagans/composer-patches`
* Adds composer patch for doctrine/dbal variable
  interpolation issue in postgres platform class
* re-arranging pre-merge and nightly tests
* Ensures to execute some acceptance and functional
  tests against MariaDB 10.6 (LTS)
* Adds a little workaround (ignore-platform-reqs)
  for composer install min and max with PHP8.2 in
  `Build/Scripts/runTests.sh` and docker-compose.yml

Used command(s):

> composer2-74 config --no-plugins --no-interaction \
    allow-plugins.cweagans/composer-patches true
> composer2-74 config --no-plugins --no-interaction \
    extra.composer-exit-on-patch-failure true
> composer2-74 config --no-plugins --no-interaction \
    extra.patches-file "Build/patches/patches.json"
> composer2-74 require --dev \
    "cweagans/composer-patches":"^1.7.1"

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 3051

Show 1326 earlier messages
  1. Stefan Bürk uploaded patch set 1 10/08/22, 19:26

  2. core-ci voted on patch set 1 V -1 10/08/22, 19:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32109

  3. Stefan Bürk uploaded patch set 2 10/08/22, 19:41

  4. core-ci voted on patch set 2 V -1 10/08/22, 19:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32110

  5. Stefan Bürk uploaded patch set 3 10/11/22, 09:16

  6. core-ci voted on patch set 3 V -1 10/11/22, 09:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32192

  7. core-ci commented on patch set 3 10/11/22, 09:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32192

  8. Stefan Bürk uploaded patch set 4 10/11/22, 10:50

  9. core-ci voted on patch set 4 V +1 10/11/22, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32199

  10. Stefan Bürk uploaded patch set 5 10/18/22, 00:03

  11. core-ci voted on patch set 5 V +1 10/18/22, 00:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32407

  12. Stefan Bürk uploaded patch set 6 10/19/22, 16:22

  13. Stefan Bürk uploaded patch set 7 10/19/22, 16:23

  14. core-ci voted on patch set 6 V -1 10/19/22, 16:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32468

  15. core-ci voted on patch set 7 V -1 10/19/22, 16:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32469

  16. Stefan Bürk uploaded patch set 8 10/22/22, 21:43

  17. core-ci voted on patch set 8 V -1 10/22/22, 21:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32623

  18. Stefan Bürk updated the commit message in patch set 9 10/23/22, 10:33

  19. core-ci voted on patch set 9 V -1 10/23/22, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32646

  20. Stefan Bürk uploaded patch set 10 10/23/22, 10:54

  21. core-ci voted on patch set 10 V +1 10/23/22, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32651

  22. Stefan Bürk uploaded patch set 11 V +1 11/23/22, 22:21

  23. core-ci voted on patch set 11 V +1 11/23/22, 22:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34142

  24. Stefan Bürk uploaded patch set 12 V +1 11/23/22, 23:13

  25. core-ci voted on patch set 12 V +1 11/23/22, 23:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34143

  26. Stefan Bürk commented on patch set 12 11/23/22, 23:22

  1. core-ci voted on patch set 12 V -1 11/23/22, 23:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34144

  2. Stefan Bürk uploaded patch set 13 V -1 11/23/22, 23:37

  3. Stefan Bürk uploaded patch set 14 11/23/22, 23:42

  4. Stefan Bürk uploaded patch set 15 11/23/22, 23:44

  5. core-ci voted on patch set 15 V +1 11/23/22, 23:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34147

  6. Stefan Bürk commented on patch set 15 11/23/22, 23:56

  7. core-ci commented on patch set 15 11/24/22, 00:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34148

  8. Stefan Bürk updated the commit message in patch set 16 V +1 11/24/22, 00:17

  9. core-ci voted on patch set 16 V +1 11/24/22, 00:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34149

  10. Chris Müller commented on patch set 16 11/24/22, 05:28

    patches-notes.txt:11

    Should be "users"
  11. Stefan Bürk uploaded patch set 17 V +1 11/24/22, 08:41

  12. Stefan Bürk commented on patch set 17 11/24/22, 08:42

    patches-notes.txt:11 Reply

    Done
  13. core-ci voted on patch set 17 V +1 11/24/22, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34161

  14. Christian Kuhn commented on patch set 17 11/28/22, 10:30

    minor cleanups, will play around soon, looks good in general.

    acceptance-application.yml:33

    still uses php 8.1, but is advertised as 8.2 above.

    acceptance-install.yml:32

    same as other comment.

    acceptance-install.yml:67

    same as other comment
  15. Christian Kuhn commented on patch set 17 11/29/22, 10:15

    acceptance-application.yml:33 Reply

    Done

    acceptance-install.yml:32 Reply

    Done

    acceptance-install.yml:67 Reply

    Done
  16. Christian Kuhn uploaded patch set 18 V +1 11/29/22, 10:15

  17. core-ci voted on patch set 18 V +1 11/29/22, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34356

  18. core-ci commented on patch set 18 11/29/22, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34357

  19. Christian Kuhn voted on patch set 18 V +1 CR +1 11/29/22, 11:08

  20. Nikita Hovratov uploaded patch set 19 CR +1 V +1 12/01/22, 10:17

  21. Nikita Hovratov voted on patch set 19 V +1 CR +1 12/01/22, 10:18

  22. Christian Kuhn voted on patch set 19 V +1 CR +1 12/01/22, 10:23

  23. core-ci voted on patch set 19 V +1 12/01/22, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34465

  24. Stefan Bürk voted on patch set 19 V +2 CR +2 12/01/22, 11:25

  25. Stefan Bürk merged patch set 20 12/01/22, 11:25