Review main Merged

76035[BUGFIX] Ensure proper identifier quoting in AbstractMenuContentObject

Stefan Bürk CR +2 V +2 Easy +5 −3 updated 10/10/22, 13:14

Commit message

PostgresSQL seems to get picky with upper case column names, if
they are not proper quoted in queries, like `pages.SYS_LASTCHANGED`
as example. Executing such database queries will return database
error message like

 ERROR:  column "sys_lastchanged" does not exist

also it has been provided as upper case variant. Related to system
architecture and historical build up sometimes sql parts are build
manually instead of using QueryBuilder directly. Thus fields and
values are eventually not properly quoted, thus leading to this
error message.

This can be verified using ext:styleguide frontend pages and open
the `/menu-recently-updated` using postgres dbms backend.

This change ensures proper quoting for build up of the extraWhere
(or additionalWhere) in core content object class
`\TYPO3\CMS\Frontend\ContentObject\Menu\AbstractMenuContentObject`.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1