Review 11.5 Merged

76055[BUGFIX] Ensure `DB Check`->`Full Search` module works with PostgresSQL

Stefan Bürk CR +2 V +2 Easy +38 −5 updated 10/10/22, 16:31

Commit message

PostgresSQL is really picky about types and used operators. Thus using
for example a `like` comparision on non string/text based fields fails
hard. Database errors like following indicates this issue:

>  Undefined function: 7 ERROR: operator does not exist:
>  smallint ~~ unknown

This changes implicit converts field data to a text representation
for PostgresSQL, if field is not compatible. In case of small/tinyint
fields a double cast is used, means casting to integer and then to
string before applying the like comparison on it.

The choosen solution is used to have a comparible behaviour against the
other supported dbms systems like MariaDB, MySQL and SQLite, also doing
a full search on all fields may be a bad decision. The whole search and
full-search across all types should be reconsidered generally.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1