Review 11.5 Merged

76064[TASK] Add tests for GeneralUtility::implodeAttributes

Georg Ringer CR +2 V +2 Normal +50 −8 updated 10/13/22, 14:30

Commit message

This change renames some variables within
GeneralUtility::implodeAttributes and adds some first
tests to this method.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Georg Ringer commented on patch set 1 10/13/22, 07:49

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/13/22, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32273

  3. Benni Mack voted on patch set 1 V +2 CR +2 10/13/22, 14:30

  4. Benni Mack merged patch set 2 10/13/22, 14:30