Review 11.5 Merged

76069[BUGFIX] Assure a string is passed to `octdec` function

Benni Mack CR +2 V +2 Easy +2 −2 updated 10/14/22, 10:39

Commit message

Since strict types were enabled for the GeneralUtility class, the
`GU::createDirectoryPath()` may throw an exception if
`$GLOBALS['TYPO3_CONF_VARS']['SYS']['folderCreateMask']` is not
set. This is due to the fact that the fallback value is an integer,
whereas the `octdec` function requires a string to be passed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Benni Mack commented on patch set 1 10/14/22, 10:31

    Cherry Picked from branch main.
  2. Oliver Klee voted on patch set 1 CR +1 10/14/22, 10:37

  3. core-ci voted on patch set 1 V +1 10/14/22, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32324

  4. Benni Mack voted on patch set 1 V +2 CR +2 10/14/22, 10:39

  5. Benni Mack merged patch set 2 10/14/22, 10:39