Review main Merged

76081[TASK] Make TreeFromLineStreamBuilder a stateless service

Christian Kuhn CR +2 V +2 Normal +28 −38 updated 10/11/22, 06:32

Commit message

TypoScript related TreeFromLineStreamBuilder has state
due to setTokenizer(), it should be "shared: false" in DI.

We can make it stateless by avoiding the explicit
set tokenizer and turning it into a mandatory argument
of buildTree(). This makes all stateful properties
mandatory arguments of the single entry method, which
makes the class effectively stateless since all state
is set a-new with next call.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 3