Review main Merged

76099[TASK] Make TreeBuilder a stateless service

Christian Kuhn CR +2 V +2 Normal +52 −64 updated 10/12/22, 11:19

Commit message

We can avoid ugly setters in TypoScript TreeBuilder
class by handing over arguments to the main function,
effectively making this service stateless.

Especially cache and tokenizer should not be injected
since they are runtime dependencies and should be given
as arguments from controllers.

$forceProcessExtensionStatics is an extbase specific
thing kept for now, but it will be solved differently
later, when extbase BackendConfigurationManager switches
to new TypoScript parser.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 7