Review main Merged

76106[TASK] More efficient FE TypoScript cache layer

Christian Kuhn CR +2 V +2 Hard +576 −279 updated 10/21/22, 10:33

Commit message

The patch changes TSFE getFromCache() to leverage more
effective TypoScript cache layers, possible with the
new TypoScript parser.

The forge issue comes with a test bed with some
measurements. The main takeaways are:

* First page call on empty caches is slower. This is because
  the new TypoScript parser creates many more objects, creates
  various additional cache entries and can parse more details.
  We may be able to mitigate this with a warmup CLI that can be
  called after deployment later. With further development, we may
  also be able to remove the b/w compat related "array representation"
  of the TypoScript AST, avoiding a time consuming operation.
  The latter however will only materialize in v13, earliest.

* Full-page cache access is slightly slower. This is mainly due
  to a sys_template query which we *may* be able to combine with
  another query in further v12 development, and makeInstance() is
  being used a bit more often, giving DI more hard work. The difference
  to v11 isn't *that* huge, and unrelated v12 related changes influence
  this as well.

* When a first page has been called, and a second page is called
  afterwards that shares the same or at least "similar" TypoScript,
  this is *significantly* quicker since TypoScript caches are now
  re-used in between different pages, which has never been the case
  before. This is a huge win and works in-between different sites as
  well, when different sites use "similar" TypoScript includes: They
  still warmup each other.

* Calling _INT content objects on pages are *significantly* and
  *systematically* quicker. This is because full TypoScript can
  be cached and shared between pages now, and other layers kick in
  if that wasn't successful. This means repeated calls to pages with
  inexpensive _INT objects now show similar speed to full-cached
  pages, while this has been a factor of at least five before.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 21

Show 1 more file