Review main Merged

76108[BUGFIX] Fix PHP warning when checking for resource collection object

Felix Nagel CR +2 V +2 Easy +1 −6 updated 10/14/22, 10:12

Commit message

Used command(s):

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Felix Nagel uploaded patch set 1 10/13/22, 10:49

  2. core-ci voted on patch set 1 V -1 10/13/22, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32283

  3. Oliver Klee commented on patch set 1 10/13/22, 12:51

    We'll need to update the PHPStan baseline as this change fixes one warning.
  4. Stefan Bürk commented on patch set 1 CR -1 10/13/22, 13:42

    Reply

    on it
  5. Stefan Bürk uploaded patch set 2 10/13/22, 13:43

  6. core-ci voted on patch set 2 V +1 10/13/22, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32293

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 10/13/22, 13:52

  8. Oliver Klee voted on patch set 2 CR +1 10/13/22, 15:15

  9. Benni Mack voted on patch set 2 V +2 CR +2 10/14/22, 10:12

  10. Benni Mack merged patch set 3 10/14/22, 10:12