Review main Merged

76109[BUGFIX] Correct prefixing of additional css files for ckeditor5

Benjamin Kott CR +2 V +2 Easy +24 −3 updated 10/13/22, 12:28

Commit message

Some CSS minifier remove the semicolon before the curly brace
While this is valid CSS, the ScssPHP Parser is unable to identify
the end of a declaration block. We are adding them, to avoid
parsing errors. Superfluous semicolons will be dropped by the parser

Moving CSS variables assigned to :root to the new parent.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 69

  1. Benjamin Kott uploaded patch set 1 10/13/22, 11:07

  2. Benjamin Kott uploaded patch set 2 10/13/22, 11:08

  3. Benjamin Kott uploaded patch set 3 10/13/22, 11:16

  4. core-ci voted on patch set 2 V +1 10/13/22, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32286

  5. core-ci voted on patch set 1 V +1 10/13/22, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32285

  6. core-ci voted on patch set 3 V +1 10/13/22, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32287

  7. Andreas Kienast voted on patch set 3 V +1 CR +1 10/13/22, 11:30

  8. Benni Mack voted on patch set 3 V +2 CR +2 10/13/22, 12:28

  9. Benni Mack merged patch set 4 10/13/22, 12:28