Review 11.5 Merged

76110[BUGFIX] Use current link text in link hook

Roman Büchler CR +2 V +2 Easy +3 −1 updated 11/07/22, 19:59

Commit message

The typoLink_PostProc hook passed the
original link text to the hook processors.
In case the `linktxt` array field isn't
altered in a hook processor the original
link text is rendered instead of the one
already available in the
`lastTypoLinkResult`. As a result the
typoscript configuration `config.
spamProtectEmailAddresses_atSubst = (at)`
isn't respected.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Roman Büchler uploaded patch set 1 10/13/22, 13:04

  2. core-ci voted on patch set 1 V -1 10/13/22, 13:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32289

  3. Benni Mack wrote 10/16/22, 20:39

    Change destination moved from main to 11.5 Change isn't relevant for 12/main - moved this to v11 branch
  4. Benni Mack rebased onto patch set 2 11/02/22, 11:51

  5. Benni Mack commented on patch set 2 11/02/22, 11:51

    Hi Roman, this might be a v11 only problem, am I right here?
  6. core-ci voted on patch set 2 V +1 11/02/22, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32980

  7. Roman Büchler commented on patch set 2 11/02/22, 12:23

    Reply

    Hi Benni, I am sorry I just tested it with v11 and saw that with v12 the hook isn't used any more. Please let me know if it should be tested with v10 as well.
  8. Benni Mack updated the commit message in patch set 3 11/03/22, 11:27

  9. Benni Mack voted on patch set 3 CR +1 11/03/22, 11:27

  10. Benni Mack voted on patch set 3 V +1 11/03/22, 11:27

  11. core-ci voted on patch set 3 V +1 11/03/22, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33037

  12. Susi Moog voted on patch set 3 V +1 CR +1 11/07/22, 19:59

  13. Benni Mack voted on patch set 3 V +2 CR +2 11/07/22, 19:59

  14. Benni Mack merged patch set 4 11/07/22, 19:59