Review main Merged

76111[TASK] Update to PHPStan 1.8.9

Oliver Klee CR +2 V +2 Easy +8 −18 updated 10/14/22, 08:35

Commit message

This update gets rid of some false positives.

Run commands:

> composer req --dev phpstan/phpstan:^1.8.9
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 45

  1. Oliver Klee uploaded patch set 1 10/13/22, 15:56

  2. core-ci voted on patch set 1 V +1 10/13/22, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32301

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 10/14/22, 02:18

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 10/14/22, 08:35

  5. Andreas Kienast merged patch set 2 10/14/22, 08:35