Review main Merged

76112[BUGFIX] Avoid undefined array key for bodyTagCObject

Karsten Nowak CR +2 V +2 Easy +1 −1 updated 10/14/22, 07:46

Commit message

Fix warning if bodyTagCObject is referenced in TypoScript template.
Set as empty array.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Elias Häußler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Elias Häußler +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Karsten Nowak uploaded patch set 1 10/14/22, 06:40

  2. core-ci voted on patch set 1 V +1 10/14/22, 06:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32309

  3. Elias Häußler commented on patch set 1 10/14/22, 07:07

    RequestHandler.php:832

    The type annotation for the `$conf` parameter in `ContentObjectRenderer::cObjGetSingle` is set to `array`. Hence, I suggest to fall back to an empty array instead of `null`.
  4. Karsten Nowak uploaded patch set 2 10/14/22, 07:33

  5. Karsten Nowak commented on patch set 2 10/14/22, 07:38

    Yes, you are right. Done.

    RequestHandler.php:832 Reply

    Done
  6. core-ci voted on patch set 2 V +1 10/14/22, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32312

  7. Elias Häußler voted on patch set 2 V +1 CR +1 10/14/22, 07:41

  8. Benni Mack voted on patch set 2 V +2 CR +2 10/14/22, 07:46

  9. Benni Mack merged patch set 3 10/14/22, 07:46