Review main Merged

76114[BUGFIX] Handle the CKEditor5 option removePlugins properly

Benjamin Kott CR +2 V +2 Normal +72 −3 updated 10/14/22, 14:52

Commit message

The removePlugins option needs to be assigned
as an array in CKEditor5. While we recommended
passing the option already as an array, CKEditor4
needed a comma-separated string.

The conversion was only handled if the Integrator
passed an array, which means if someone already
provided a comma-separated string the option
was simply passed as is to the Editor.

To avoid javascript errors we are going to migrate
it to array for now. The possibility to pass the option
as a string is deprecated and will be removed with
version 13.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1115

  1. Benjamin Kott uploaded patch set 1 10/14/22, 07:57

  2. core-ci voted on patch set 1 V +1 10/14/22, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32314

  3. Andreas Kienast commented on patch set 1 CR -1 10/14/22, 08:33

    Please provide a deprecation rst.
  4. Benjamin Kott uploaded patch set 2 10/14/22, 09:49

  5. core-ci voted on patch set 2 V +1 10/14/22, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32321

  6. Benni Mack voted on patch set 2 V +1 CR +1 10/14/22, 10:29

  7. Benjamin Kott rebased onto patch set 3 10/14/22, 11:11

  8. core-ci voted on patch set 3 V +1 10/14/22, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32326

  9. Benni Mack voted on patch set 3 V +1 CR +1 10/14/22, 11:20

  10. Andreas Kienast commented on patch set 4 10/14/22, 11:48

    Published edit on patch set 3.
  11. Andreas Kienast voted on patch set 4 V +1 CR +1 10/14/22, 11:48

  12. Benni Mack voted on patch set 4 V +2 CR +2 10/14/22, 11:51

  13. core-ci voted on patch set 4 V +1 10/14/22, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32332

  14. Benni Mack merged patch set 5 10/14/22, 11:56

  15. Oliver Hader voted on patch set 5 CR +1 10/14/22, 14:52