Review main Merged

76154[BUGFIX] Bind backend search events only once

Andreas Kienast CR +2 V +2 Easy +2 −5 updated 10/18/22, 10:18

Commit message

The event handlers for the backend search are now bound only once, when
the DOM becomes ready to fix event handler stacking when the topbar is
reloaded, due to an extension (un)installation in the extension manager.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 812

  1. Andreas Kienast uploaded patch set 1 10/18/22, 08:32

  2. Andreas Kienast updated the commit message in patch set 2 10/18/22, 08:33

  3. core-ci voted on patch set 2 V -1 10/18/22, 08:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32420

  4. core-ci voted on patch set 1 V -1 10/18/22, 08:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32419

  5. Andreas Kienast uploaded patch set 3 10/18/22, 08:52

  6. Andreas Kienast uploaded patch set 4 10/18/22, 08:54

  7. core-ci voted on patch set 3 V +1 10/18/22, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32424

  8. core-ci voted on patch set 4 V +1 10/18/22, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32425

  9. Benni Mack voted on patch set 4 V +1 CR +1 10/18/22, 09:37

  10. Simon Schaufelberger voted on patch set 4 V +1 CR +1 10/18/22, 10:09

  11. Andreas Kienast voted on patch set 4 V +2 CR +2 10/18/22, 10:18

  12. Andreas Kienast merged patch set 5 10/18/22, 10:18