76155[TASK] Optimize default dashboard
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 2224
-
Frank Nägler uploaded patch set 1 10/18/22, 08:34
-
Oliver Klee updated the commit message in patch set 2 10/18/22, 08:40
-
Oliver Klee commented on patch set 2 10/18/22, 08:49
I've updated the commit message. In general, the commit message lines should be short enough so that they don't get wrapped in Gerrit. -
core-ci voted on patch set 1 V -1 10/18/22, 08:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32421
-
core-ci voted on patch set 2 V -1 10/18/22, 08:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32422
-
Christian Kuhn commented on patch set 2 CR -1 10/18/22, 10:49
we actively removed 'phone home' default dashboards. i think we shouldn't introduce them again. -
Benjamin Kott commented on patch set 2 10/18/22, 11:08
I really cannot see a problem here with phoning home. I guess you refer to the RSS feeds. I really think we need to provide more useful information here by default. Especially for starters to get around the system and see what's going on. -
Oliver Klee commented on patch set 2 10/18/22, 11:17
What will happen if the dashboard is opened on a local installation without internet connection (e.g., when someone is developing on a train)? -
Christian Kuhn commented on patch set 2 10/18/22, 11:26
https://review.typo3.org/c/Packages/TYPO3.CMS/+/73059 has some reasoning: fine to have dashboards configured, but no default dashboard with these enabled. -
Benjamin Kott commented on patch set 2 10/18/22, 13:11
I still can not see a problem here from a privacy perspective. I think we can solve the issue for the CI environment and avoid requests here at all. If not data could be fetched and no cache is available it should simply state that no data could be fetched. -
Christian Kuhn commented on patch set 2 10/18/22, 15:28
the dashboard is the default view after backend login in for editors. adding a "phones home by default" view here adds tons of calls to typo3.org for many default instances with editor users, potentially allowing tracing of instances, versions and instance activity. how can you not see a privacy issue with that? there is zero benefit for us as an open source project to go this path. we changed that in linked issue for exactly these reasons and there has also been a discussion about it back then. when you want a better default widget view, then please start adding widgets that are actually useful and add value to editors: "which elements changed since" for instance, "what did user x change last?", "which workspace elements are in ready to publish state that i worked on", "when were latest news records released", "which timed records will go live next": the dashboard is not great for editors because there are no useful default widgets, not because 'latest typo3.org news' aren't shown. add some actually useful widgets for editors and this discussion resolves itself without adding widgets that are questionable from a privacy point. -
Stefan Bürk commented on patch set 2 10/18/22, 20:24
From our customers and editors perspective, the dashobard is the "less usefull view" in the backend at all. It's just a step to get over it. None of them are interested in any feed. And as a developer, i'm not interessted at all in it to. Unless there are really usefull widgets and information which really helps the editors with there daily work (pending reviews in workspaces, last edited pages/elemens, etc etc etc) or configurable team stats ). Adding feeds there are absolutly uninteressting for them. I viewed selection. There is nothing really valuable for our people, editors and workes there. It does not make any difference at all. And I doupt a starter will have much gain from even the new "selection". So pullating this as a default is for the most instances not a usefull thing. And I'm even not sure if a "starter" gain so much from these feeds in the dashboard. And it has not so good side effects on acceptance test executions. Basicly fine with the change, except adding the two feeds back again ... -
Benjamin Kott commented on patch set 2 10/18/22, 21:15
ok let me declutter this. 1. i really don't see a request problem here. Widget can cache, platform can deliver cached results. if that's our problem we have a different problem. 2. using planet to share a selected articles from multiple sources is the best single opportunity to inform users about what's going on in the universe is the best shot we currently have on this one. it may not be interested for all users 3. it's the default it will be replaced, or the dashboard disabled if there is no interest at all. Anyone that has the default dashboard running has it not configured or is just too lazy to remove/change the entry point, or did not do his job providing a useful one. 4. since planet is an aggregator it will show a feed combined from .org / .com and selected community blogs. since not all devs are informed they will atleast get a glimse what's going on everytime they start a new project. that's informing developers, I am not talking about Gerrit and forge users, not even Twitter and Facebook people. No Slack, we need to engage them somehow. 5. if having requests declared as a security that land on. servers maintained by our serverteam - we should also have a different conversation, means we don't trust our own servers with a project from, for the community, demanded by the community - different story. 6. anyways, the goal should be having a good starter experience, not regular developers hardcore developers that ignore anything they see. so hopefully no one feels hurt if that's the case ping me please to clarify. If I rephrase this correctly, biggest Painpoints: - Requests amount (solved/solveable) - Acceptance tests (solveable) - Outgoing requests without permission < blocker?! I guess for the blocker we also can find a solution. what do you think about widgets you need to enable but are there by default? Like "Allow fetching data" or during the installation process an opt-in? would really like to find a suitable solution to this. -
Markus Klein commented on patch set 2 10/20/22, 15:09
Reply Unresolved
+1 on all 6 points from my side. my POV regarding the "blocker": If this should not happen, I suspect that we talk about a security level, where outgoing requests are opt-in on a host/firewall level anyways. So the request would simply fail, unless explicitly allowed in the firewall => fetch RSS data async and we are good, right? -
Oliver Klee commented on patch set 2 10/20/22, 15:15
Reply
This is not resolved yet. (I remember some part of the BE not being usable some time (years?) ago when I was working in offline mode.) -
Frank Nägler commented on patch set 2 11/10/22, 14:32
Benji pointed out some reasons and questions. Until now, only Markus reacted, so how to proceed here? Regarding online/offline usage, the RssWidget uses the GU::getUrl function and takes care of these issues. Concrete: If the feed can't be fetched, the widget shows the message: > An error occurred while retrieving information for this widget. Please try again, and if the problem persists, contact your administrator. So I can't see a blocker in this area. In general, the widgets are non-blocking by default. -
Oliver Klee wrote 11/10/22, 15:33
Removed cc Oliver Klee. -
Christian Kuhn voted on patch set 2 CR -2 11/10/22, 21:25
-
Christian Kuhn commented on patch set 2 11/11/22, 08:11
Hey. Thanks for coming back to this. I don't understand why we're still discussing here. I hope we agree the main target group of the dashboard is of course not admins but editors. They log in to the Backend of an instance to edit content, not to be informed about latest shop.typo3.com merch. When asking in the community if they install the dashboard on their instances, the answer is often: "No, because it simply does not provide enough useful widgets for editors". It is not "No, because it does not show me latest TER extension releases". Let's not loose our time in making these widgets less problematic from a privacy point of view by adding a button "Are you ok with fetching remote content". This simply does not help us. The dashboard has been introduced in v10 with a very restricted set of widgets and nothing has happened with the extension in this area until now. Let's stop continuing this way and start adding widgets that add useful information for editors. I mentioned a couple of simple ones already that would help giving editors a better overview on what is happening in an instance, could simplify and improve their work, and helps collaboration with other editors. Please go ahead and think about further things we could add on this level: This is the only way to increase acceptance of the dashboard extension. So, please, let's stop discussing on shady 'phone home' and 'typo3.com wants to sell me something' widgets. Instead, spend time on editor based widgets that actively help them. -
Oliver Klee commented on patch set 2 11/11/22, 08:12
Reply
Ack -
Oliver Klee wrote 11/11/22, 08:12
Removed cc Oliver Klee. -
Mathias Bolt Lesniak commented on patch set 2 01/08/23, 02:53
Reply Unresolved
> So, please, let's stop discussing on shady 'phone home' and 'typo3.com wants to sell me something' widgets. Instead, spend time on editor based widgets that actively help them. Some thoughts from me: This is an interesting discussion, and Christian has a good point here. Not that I think phoning home is bad, when done right, but IMHO it's just not the task of an RSS feed. And advertising products and services doesn't have to be wrong either, if done right, because it's a source of income for the project. However, what widgets are useful depend on the user. Could it be an idea to provide different default dashboards for different user types? I imagine maintainers would have a different need than admins from support. And end-users would probably benefit from a feed from typo3.com, rather than one from typo3.org (.com is supposed to have content for less techy people). I'm also of the opinion that the RSS feeds should only use official feeds of vetted content. I'm not sure a feed from planet.typo3.org would be the best. :-) -
Christian Kuhn commented on patch set 2 02/03/23, 12:48
talked with frank on latest sprint and he's fine with abandoning this approach. doing so now. -
Christian Kuhn abandoned the change 02/03/23, 12:48