Review main Merged

76161[BUGFIX] Interpolate log messages in InMemoryLogWriter

Sascha Egerer CR +2 V +2 Easy +1 −1 updated 10/21/22, 22:18

Commit message

Log messages may have placeholders that must be interpolated
based on the context provided to the message.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Sascha Egerer uploaded patch set 1 10/18/22, 22:00

  2. core-ci voted on patch set 1 V +1 10/18/22, 22:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32445

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 10/21/22, 08:44

  4. Christian Kuhn updated the commit message in patch set 2 10/21/22, 22:03

  5. Christian Kuhn commented on patch set 2 10/21/22, 22:03

    removed v10: not critical.
  6. Stefan Bürk voted on patch set 2 V +1 CR +1 10/21/22, 22:05

  7. core-ci voted on patch set 2 V +1 10/21/22, 22:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32604

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 10/21/22, 22:18

  9. Christian Kuhn merged patch set 3 10/21/22, 22:18