Review main Merged

76218[BUGFIX] Animate docheader folding via CSS transitions

Andreas Kienast CR +2 V +2 Easy +3 −3 updated 10/21/22, 18:02

Commit message

A backend module's docheader is "folded" when scrolling down in the
backend module. Sometimes, the folding process appears to be laggy due
to the pixel-snapping approach of animating a position change, which also
leads to more work for browser engines.

For a better rendering performance, the element isn't physically moved in
the DOM, but transformed instead, offloading work to the GPU.

See [1] for further information.

[1] https://web.dev/animations-overview/

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Andreas Kienast uploaded patch set 1 10/21/22, 13:39

  2. core-ci voted on patch set 1 V +1 10/21/22, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32585

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 10/21/22, 14:44

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 10/21/22, 17:58

  5. Andreas Kienast commented on patch set 1 V +2 CR +2 10/21/22, 18:02

    Will take care of the backport ASAP
  6. Andreas Kienast merged patch set 2 10/21/22, 18:02