Review main Merged

76224[TASK] Optimize FE page locking

Christian Kuhn CR +2 V +2 Normal +108 −103 updated 10/22/22, 10:03

Commit message

This is a clean up and optimization.

First, TSFE->lock does not need to be a multi
dimensional array anymore since the removal of
pagesection cache. This is simplified.

Also releaseLock() is useless since we're dealing
with only one lock-type since removal of pagesection
cache, so we merge it with public releaseLocks().

Additionally, acquireLock() now returns an
information if it got the lock immediately or had to
wait. Having this information, we can suppress a
cache->get() in case we got the lock immediately.

We mirror the acquire and release changes to class
ResourceMutex, which is codewise identical to the
methods from TSFE. We'll switch to this object in
TSFE with another patch.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 3