Review main Merged

76228[TASK] Correct return type annotations for FAL addFile

Markus Klein CR +2 V +2 Easy +14 −27 updated 08/06/24, 16:48

Commit message

The `addFile` method may return
> FileInterface|File|ProcessedFile|null
which can be simplified to
> File
as it is never used in conjuction with processed files.

Adjust all usages and type annotations accordingly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1625

  1. Markus Klein uploaded patch set 1 10/22/22, 14:03

  2. core-ci voted on patch set 1 V -1 10/22/22, 14:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32619

  3. Markus Klein uploaded patch set 2 V -1 07/22/24, 11:50

  4. Markus Klein marked it ready for review 07/22/24, 11:50

  5. Markus Klein updated the commit message in patch set 3 07/22/24, 11:53

  6. core-ci voted on patch set 2 V -1 07/22/24, 11:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61926

  7. core-ci voted on patch set 3 V -1 07/22/24, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61927

  8. Markus Klein uploaded patch set 4 V -1 07/22/24, 14:26

  9. Markus Klein uploaded patch set 5 07/22/24, 14:32

  10. core-ci voted on patch set 4 V -1 07/22/24, 14:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61932

  11. core-ci voted on patch set 5 V -1 07/22/24, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61933

  12. Markus Klein uploaded patch set 6 V -1 07/22/24, 14:53

  13. core-ci voted on patch set 6 V +1 07/22/24, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61934

  14. Christian Kuhn commented on patch set 6 07/24/24, 11:13

    ResourceStorage.php:1452

    nit: please use `@todo` to find such annotations more easily.

    ResourceStorage.php:1613

    nit: please use `@todo` to find such annotations more easily.
  15. Markus Klein commented on patch set 7 V +1 07/24/24, 12:56

    Published edit on patch set 6.
  16. Markus Klein commented on patch set 7 07/24/24, 12:56

    ResourceStorage.php:1452 Reply

    Done

    ResourceStorage.php:1613 Reply

    Done
  17. Markus Klein updated the commit message in patch set 8 07/24/24, 12:57

  18. core-ci voted on patch set 7 V -1 07/24/24, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62096

  19. core-ci voted on patch set 8 V -1 07/24/24, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62097

  20. Christian Kuhn rebased onto patch set 9 V -1 08/06/24, 16:37

  21. core-ci voted on patch set 9 V +1 08/06/24, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62960

  22. Christian Kuhn voted on patch set 9 CR +1 V +1 08/06/24, 16:44

  23. Andreas Nedbal voted on patch set 9 CR +1 V +1 08/06/24, 16:46

  24. Christian Kuhn voted on patch set 9 CR +2 V +2 08/06/24, 16:48

  25. Christian Kuhn merged patch set 10 08/06/24, 16:48