76228[TASK] Correct return type annotations for FAL addFile
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Andreas Nedbal +1
-
Verified V +2 Done
- Christian Kuhn +2
- Andreas Nedbal +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1625
-
Markus Klein uploaded patch set 1 10/22/22, 14:03
-
core-ci voted on patch set 1 V -1 10/22/22, 14:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32619
-
Markus Klein uploaded patch set 2
V -107/22/24, 11:50 -
Markus Klein marked it ready for review 07/22/24, 11:50
-
Markus Klein updated the commit message in patch set 3 07/22/24, 11:53
-
core-ci voted on patch set 2 V -1 07/22/24, 11:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61926
-
core-ci voted on patch set 3 V -1 07/22/24, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61927
-
Markus Klein uploaded patch set 4
V -107/22/24, 14:26 -
Markus Klein uploaded patch set 5 07/22/24, 14:32
-
core-ci voted on patch set 4 V -1 07/22/24, 14:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61932
-
core-ci voted on patch set 5 V -1 07/22/24, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61933
-
Markus Klein uploaded patch set 6
V -107/22/24, 14:53 -
core-ci voted on patch set 6 V +1 07/22/24, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61934
-
Christian Kuhn commented on patch set 6 07/24/24, 11:13
ResourceStorage.php:1613nit: please use `@todo` to find such annotations more easily. -
Markus Klein commented on patch set 7
V +107/24/24, 12:56Published edit on patch set 6. -
Markus Klein commented on patch set 7 07/24/24, 12:56
ResourceStorage.php:1452ReplyDoneResourceStorage.php:1613ReplyDone -
Markus Klein updated the commit message in patch set 8 07/24/24, 12:57
-
core-ci voted on patch set 7 V -1 07/24/24, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62096
-
core-ci voted on patch set 8 V -1 07/24/24, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62097
-
Christian Kuhn rebased onto patch set 9
V -108/06/24, 16:37 -
core-ci voted on patch set 9 V +1 08/06/24, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62960
-
Christian Kuhn voted on patch set 9 CR +1 V +1 08/06/24, 16:44
-
Andreas Nedbal voted on patch set 9 CR +1 V +1 08/06/24, 16:46
-
Christian Kuhn voted on patch set 9 CR +2 V +2 08/06/24, 16:48
-
Christian Kuhn merged patch set 10 08/06/24, 16:48
ResourceStorage.php:1452