Review main Merged

76234[BUGFIX] Make CE actions clickable after visibility toggle

Andreas Kienast CR +2 V +2 Easy +3 −1 updated 10/24/22, 13:37

Commit message

When a content element gets hidden or visible, the page module is
reloaded with an anchor in the URL to scroll to the content element
that was updated.

After #98471 it was not possible anymore to click the "+ Content"
button above such element unless it was dragged and dropped again into
the same column. The reason is that a pseudo element `:target:before`
is generated with a specific height and margin to overcome the height of
the floating module docheader, overlaying the CE action button.
In the patch mentioned before, relative positioning was added to the
columns as this is needed for the dropzones, finally causing this bug.

To solve this issue, the CE actions now have a higher z-index to be
clickable again.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 45

  1. Andreas Kienast uploaded patch set 1 10/23/22, 09:45

  2. core-ci voted on patch set 1 V +1 10/23/22, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32642

  3. Benni Mack voted on patch set 1 V +1 CR +1 10/24/22, 10:50

  4. Georg Ringer voted on patch set 1 V +2 CR +2 10/24/22, 13:37

  5. Georg Ringer merged patch set 2 10/24/22, 13:37