Review main Merged

76241[BUGFIX] CKEditor 4 Anchor Button is incorrectly handled as link in CKEditor 5 migration

Benjamin Kott CR +2 V +2 Easy +7 −1 updated 10/26/22, 08:18

Commit message

CKEditor 5 changed the way it handles links, and
introduced new modules to do so. In the automatic
migration from CKEditor 4 to CKEditor 5 configuration
the previously available separate button "Anchor" is
is incorrectly migrated to the new "link" module.

In CKEditor 4 there was a differentiation between
outgoing links (https://, relative etc.) and anchors on
the current page (aka #). CKEditor did not make
this differentiation anymore and introduced a unified
link handling. There is no replacement for "Anchor"
in the new configuration.

Keeping the migration would resolve in unintentionally
removing the capability of setting links in general, since
it would remove the new overarching plugin.

In addition, we are now also cleaning up the legacy
configuration after migration for removeButtons
and format_tags.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 711

  1. Benjamin Kott uploaded patch set 1 10/24/22, 08:08

  2. core-ci voted on patch set 1 V +1 10/24/22, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32675

  3. Chris Müller updated the commit message in patch set 2 10/24/22, 10:12

  4. core-ci voted on patch set 2 V +1 10/24/22, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32678

  5. Benjamin Kott uploaded patch set 3 10/24/22, 11:41

  6. core-ci voted on patch set 3 V +1 10/24/22, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32684

  7. Benjamin Kott rebased onto patch set 4 10/25/22, 12:44

  8. core-ci voted on patch set 4 V +1 10/25/22, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32738

  9. Benni Mack voted on patch set 4 V +1 CR +1 10/26/22, 07:54

  10. Andreas Kienast voted on patch set 4 V +2 CR +2 10/26/22, 08:18

  11. Andreas Kienast merged patch set 5 10/26/22, 08:18