Review 11.5 Merged

76256[BUGFIX] Avoid undefined array key frequencyOptions

Simon Ackermann CR +2 V +2 Easy +1 −1 updated 10/25/22, 11:04

Commit message

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Simon Ackermann uploaded patch set 1 10/25/22, 09:45

  2. Oliver Klee commented on patch set 1 10/25/22, 09:52

    Is main not affected? (If main is affected, the change should first go to main, and if that is merged, usually the merger will do the backport.)
  3. core-ci voted on patch set 1 V +1 10/25/22, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32728

  4. Oliver Klee commented on patch set 1 CR +1 10/25/22, 10:13

    I've just checked: This already has been fixed in main (probably as part of the refactoring of this class), and hence this is 11.5-only.
  5. Oliver Klee commented on patch set 1 10/25/22, 10:14

    Reply

    Done
  6. Christian Kuhn updated the commit message in patch set 2 10/25/22, 10:22

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 10/25/22, 10:22

  8. core-ci voted on patch set 2 V +1 10/25/22, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32730

  9. Oliver Klee voted on patch set 2 CR +1 10/25/22, 10:54

  10. Nikita Hovratov voted on patch set 2 V +1 CR +1 10/25/22, 10:57

  11. Georg Ringer voted on patch set 2 V +2 CR +2 10/25/22, 11:04

  12. Georg Ringer merged patch set 3 10/25/22, 11:04