Review main Merged

76266[TASK] Update jasmine and remove old launchers

Andreas Kienast CR +2 V +2 Hard +231 −342 updated 10/26/22, 07:34

Commit message

This patch updates jasmine to the current version 4.4.0. This mainly
impacts performance and dropped support for outdated environments and
browsers.

Karma is also updated and in the same run, unused launchers are removed.

Executed commands:

    npm install --save-dev \
        @types/jasmine@^4.3.0 \
        jasmine-core@^4.4.0 \
        karma@^6.4.1 \
        karma-chrome-launcher@^3.1.1 \
        karma-coverage@^2.2.0 \
        karma-jasmine@^5.1.0 \
        karma-junit-reporter@^2.0.1 \
        karma-rollup-preprocessor@^7.0.8

    npm remove \
        karma-firefox-launcher \
        karma-ie-launcher \
        karma-opera-launcher \
        karma-safari-launcher

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Andreas Kienast uploaded patch set 1 10/26/22, 07:04

  2. Andreas Kienast uploaded patch set 2 10/26/22, 07:11

  3. core-ci voted on patch set 1 V +1 10/26/22, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32776

  4. core-ci voted on patch set 2 V +1 10/26/22, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32777

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 10/26/22, 07:19

  6. Benjamin Franzke voted on patch set 2 V +2 CR +2 10/26/22, 07:34

  7. Benjamin Franzke merged patch set 3 10/26/22, 07:34