Review main Merged

76267[BUGFIX] Correct registration of toolbar link buttons in CKEditor 5

Benjamin Kott CR +2 V +2 Easy +9 −8 updated 10/27/22, 06:25

Commit message

The CKEditor 5 has very limited support for managing links.
By default, you only get a simple input field for a string.
To bring the known and loved easy-to-use LinkBrowser to
CKEditor 5 we need to overwrite the existing linking
capabilities.

For developers and integrators, this overwrite should be
invisible as it was before with the CKEditor 4 integration.
Instead of teaching the users that they need to load custom
modules to change the link behavior, we are already migrating
this in the background for them. A typical developer can just
follow the CKEditor 5 guide to configuring the editor to its
needs and the Core is already doing the adjustments and
replacements of modules for them.

We currently overwrite the existing link and unlink commands,
but we register the toolbar buttons with a prefix. This makes
existing CKEditor configurations incompatible since the
linking buttons are missing in the toolbar.

To make migrations easier we adjust custom toolbar buttons to
match the CKEditor 5 defaults and drop the custom names for
the buttons.

In addition, we are streamlining the behavior of removing plugins.
Since we are already overwriting the "Link" plugin there is no
need to remove it if no removePlugin config is passed in the first
place. This allows us to better test the behavior and reduces the
cases we need to cover in the first place.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 68

  1. Benjamin Kott uploaded patch set 1 10/26/22, 08:02

  2. core-ci voted on patch set 1 V +1 10/26/22, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32780

  3. Benjamin Kott uploaded patch set 2 10/26/22, 08:41

  4. Benni Mack commented on patch set 2 CR +1 10/26/22, 08:48

    I like it
  5. core-ci voted on patch set 2 V +1 10/26/22, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32785

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 10/26/22, 08:50

  7. Benni Mack voted on patch set 2 V +2 CR +2 10/27/22, 06:24

  8. Benni Mack merged patch set 3 10/27/22, 06:25