Review main Merged

76270[TASK] Do not scan property '$content' in extension scanner

Christian Kuhn CR +2 V +2 Easy +0 −11 updated 10/26/22, 10:01

Commit message

This property name is too generic as weak match and
throws too many false positives.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Christian Kuhn uploaded patch set 1 10/26/22, 08:43

  2. core-ci voted on patch set 1 V +1 10/26/22, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32787

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 10/26/22, 09:02

  4. Oliver Klee voted on patch set 1 CR +1 10/26/22, 09:20

  5. Oliver Klee updated the commit message in patch set 2 10/26/22, 09:20

  6. Oliver Klee voted on patch set 2 CR +1 10/26/22, 09:20

  7. core-ci voted on patch set 2 V +1 10/26/22, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32793

  8. Anja Leichsenring voted on patch set 2 V +1 CR +1 10/26/22, 09:29

  9. Benni Mack voted on patch set 2 V +1 CR +1 10/26/22, 09:56

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 10/26/22, 10:01

  11. Christian Kuhn merged patch set 3 10/26/22, 10:01