76292[TASK] Update codeception/module-webdriver, TF, styleguide
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1215
-
Christian Kuhn uploaded patch set 1 10/26/22, 11:28
-
Christian Kuhn updated the commit message in patch set 2 10/26/22, 11:29
-
Christian Kuhn commented on patch set 2 CR -1 10/26/22, 11:31
waiting for nightly. -
Stefan Bürk voted on patch set 2 V +1 CR +1 10/26/22, 11:36
-
core-ci voted on patch set 2 V +1 10/26/22, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32796
-
Oliver Klee voted on patch set 2 V +1 10/26/22, 11:46
-
Oliver Klee commented on patch set 2 10/26/22, 11:47
Would it make sense to also update php-webdriver/webdriver to 1.13.1 while we're at it? -
core-ci voted on patch set 2 V -1 10/26/22, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32797
-
Stefan Bürk voted on patch set 2 V 0 CR 0 10/26/22, 12:10
-
core-ci voted on patch set 2 V +1 10/26/22, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32797
-
Stefan Bürk commented on patch set 2 V +1 CR +1 10/26/22, 12:29
Reply
it's covered by composer install max tests. As dev dependency not really needed I would say. The raise of module-webdriver is mandantory as lolli added a PR there to add stuff needed to silence cookie messages. Thus the raise. > Upgrading php-webdriver/webdriver (1.13.0 => 1.13.1) -
Stefan Bürk commented on patch set 2 10/26/22, 12:29
Seems some hick-ups the first nightly fail. retry went through. -
Oliver Klee voted on patch set 2 CR +1 10/26/22, 13:03
-
Christian Kuhn voted on patch set 2 V +2 CR +2 10/26/22, 13:06
-
Christian Kuhn merged patch set 3 10/26/22, 13:06