Review main Merged

76296[TASK] Avoid testing 'non-writable' directory

Christian Kuhn CR +2 V +2 Easy +0 −42 updated 10/26/22, 13:46

Commit message

Testing 'non-writable' directories is flaky in
real life since it depends on the user that
executes these tests. On gitlab CI, it is useless
a-priori, since gitlab runs as root in containers.
Establishing a vfs for this does not help us much,
especially when it just tests if some exception is
thrown, which is done obviously when reading code.
This vfsStream usage is simply not worth the dependency.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2