Review main Merged

76317[TASK] Replace prophecy in EXT:extbase CacheServiceTest

Torben Hansen CR +2 V +2 Easy +5 −15 updated 10/27/22, 18:05

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Torben Hansen uploaded patch set 1 10/27/22, 17:32

  2. core-ci voted on patch set 1 V +1 10/27/22, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32852

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 10/27/22, 17:46

  4. Stefan Bürk commented on patch set 2 10/27/22, 17:47

    Published edit on patch set 1.
  5. Oliver Klee commented on patch set 2 10/27/22, 17:50

    CacheServiceTest.php:29

    Nitpick: For making the "more important" class more visible, please let's have it first, and MockObject second. Will change that in a second.
  6. Oliver Klee commented on patch set 3 10/27/22, 17:50

    Published edit on patch set 2.
  7. Oliver Klee commented on patch set 3 CR +1 10/27/22, 17:50

    CacheServiceTest.php:29 Reply

    Done
  8. core-ci voted on patch set 3 V +1 10/27/22, 17:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32855

  9. Stefan Bürk voted on patch set 3 V +1 CR +1 10/27/22, 18:00

  10. Oliver Klee voted on patch set 3 V +1 10/27/22, 18:03

  11. Stefan Bürk voted on patch set 3 V +2 CR +2 10/27/22, 18:05

  12. Stefan Bürk merged patch set 4 10/27/22, 18:05