76317[TASK] Replace prophecy in EXT:extbase CacheServiceTest
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1012
-
Torben Hansen uploaded patch set 1 10/27/22, 17:32
-
core-ci voted on patch set 1 V +1 10/27/22, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32852
-
Stefan Bürk voted on patch set 1 V +1 CR +1 10/27/22, 17:46
-
Stefan Bürk commented on patch set 2 10/27/22, 17:47
Published edit on patch set 1. -
Oliver Klee commented on patch set 2 10/27/22, 17:50
CacheServiceTest.php:29Nitpick: For making the "more important" class more visible, please let's have it first, and MockObject second. Will change that in a second. -
Oliver Klee commented on patch set 3 10/27/22, 17:50
Published edit on patch set 2. -
Oliver Klee commented on patch set 3 CR +1 10/27/22, 17:50
CacheServiceTest.php:29ReplyDone -
core-ci voted on patch set 3 V +1 10/27/22, 17:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32855
-
Stefan Bürk voted on patch set 3 V +1 CR +1 10/27/22, 18:00
-
Oliver Klee voted on patch set 3 V +1 10/27/22, 18:03
-
Stefan Bürk voted on patch set 3 V +2 CR +2 10/27/22, 18:05
-
Stefan Bürk merged patch set 4 10/27/22, 18:05