76319[TASK] Ensure to have a default showitem info when adding plugins as CType
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Georg Ringer +1
-
Verified V +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php2+9 −2
- typo3/sysext/core/Documentation/Changelog/11.5.x/Important-98960-DefaultTypeDefinitionOfCustomContentTypes.rst8new+70 −0
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+35 −0
- typo3/sysext/felogin/Configuration/TCA/Overrides/tt_content.php+8 −22
- typo3/sysext/form/Configuration/TCA/Overrides/tt_content.php+18 −31
Review log 2229
Show 24 earlier messages
-
Benni Mack uploaded patch set 1 10/27/22, 20:40
-
Benni Mack uploaded patch set 2 10/27/22, 20:45
-
core-ci voted on patch set 1 V +1 10/27/22, 20:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32859
-
core-ci voted on patch set 2 V +1 10/27/22, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32860
-
Benni Mack uploaded patch set 3 10/31/22, 11:02
-
core-ci voted on patch set 3 V +1 10/31/22, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32934
-
Oliver Hader commented on patch set 3 10/31/22, 12:07
Hm, I fail to see the connection here... did you actually mean `configurePlugin`? (`$pluginType` is resolved from `TYPO3_CONF_VARS` in `registerPlugin`)Important-98960-DefaultTypeDefinitionOfCustomContentTypes.rst:16`configurePlugin` and it's the 5th parameter -
Benni Mack uploaded patch set 4 10/31/22, 12:33
-
core-ci voted on patch set 4 V +1 10/31/22, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32935
-
Benni Mack uploaded patch set 5 10/31/22, 12:42
-
core-ci voted on patch set 5 V +1 10/31/22, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32936
-
Georg Ringer voted on patch set 5 CR +1 10/31/22, 12:56
-
Benni Mack commented on patch set 5 10/31/22, 12:56
Important-98960-DefaultTypeDefinitionOfCustomContentTypes.rst:16ReplyDone -
Nikita Hovratov voted on patch set 5 V +1 CR +1 10/31/22, 15:38
-
Stefan Bürk voted on patch set 5 V +1 CR +1 10/31/22, 15:46
-
Georg Ringer commented on patch set 5 CR -1 11/02/22, 06:13
Important-98960-DefaultTypeDefinitionOfCustomContentTypes.rst:45the return value is a new feature of v12, how to handle that in a 11.5.x rst?! -
Stefan Bürk commented on patch set 5 V 0 CR 0 11/02/22, 08:16
Important-98960-DefaultTypeDefinitionOfCustomContentTypes.rst:45ReplyYou are right, good catch ... would say the classic way, setting the variable manually before/after and leaving the return type out: ``` //$contentTypeName = strtolower($extensionName) . '_' . strtolower($pluginName); $contentTypeName = strtolower('Felogin') . '_' . strtolower('Login'); ``` -
Nikita Hovratov voted on patch set 5 V 0 CR 0 11/02/22, 08:23
-
Georg Ringer commented on patch set 5 11/02/22, 08:37
Important-98960-DefaultTypeDefinitionOfCustomContentTypes.rst:45Replyor we backport the other change as well, would love that feature for the same reason ;) or we differentiate in the RST which would be ok as well. just a strtolower is not the solution as IMO underscores in pluginName are removed -
Benni Mack commented on patch set 6 11/04/22, 09:53
Published edit on patch set 5. -
Benni Mack commented on patch set 6 11/04/22, 09:53
Important-98960-DefaultTypeDefinitionOfCustomContentTypes.rst:45Replychanged the comment for now to continue here for v11.5. -
core-ci voted on patch set 6 V +1 11/04/22, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33096
-
Oli Bartsch commented on patch set 6 11/04/22, 16:20
ExtensionManagementUtility.php:1012This might not work in case extensions unset this type.Important-98960-DefaultTypeDefinitionOfCustomContentTypes.rst:61'showitem' -
Benni Mack commented on patch set 7 11/05/22, 12:00
Published edit on patch set 6. -
Benni Mack commented on patch set 7 11/05/22, 12:00
ExtensionManagementUtility.php:1012ReplyDoneImportant-98960-DefaultTypeDefinitionOfCustomContentTypes.rst:61ReplyDone -
core-ci voted on patch set 7 V +1 11/05/22, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33144
-
Georg Ringer voted on patch set 7 V +1 CR +1 11/07/22, 20:51
-
Oli Bartsch voted on patch set 7 V +2 CR +2 11/07/22, 22:49
-
Oli Bartsch merged patch set 8 11/07/22, 22:49