Review main Merged

76319[TASK] Ensure to have a default showitem info when adding plugins as CType

Benni Mack CR +2 V +2 Normal +140 −55 updated 11/07/22, 22:49

Commit message

This change adds the basic information for a type
when adding a plugin as CType. When adding a plugin with
"list_type" (default), then the "list" CType is used,
and extension authors are able to add or remove fields
easily with the API. However, when encouraging extension authors
to use CType, this is currently much more boilerplate and not
possible to make this more flexible.

As shown, EXT:felogin and EXT:form previously used this concept
manually, which does not allow to extend fields properly,
but extensions with plugins as CTypes had to define them explicitly.

As TYPO3 Core encourages people to use custom CTypes in favor
of list_type (moving towards a unifieid Content Block concept),
this change will also be available for 11.5.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 2229

Show 24 earlier messages
  1. Benni Mack uploaded patch set 1 10/27/22, 20:40

  2. Benni Mack uploaded patch set 2 10/27/22, 20:45

  3. core-ci voted on patch set 1 V +1 10/27/22, 20:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32859

  4. core-ci voted on patch set 2 V +1 10/27/22, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32860

  1. Benni Mack uploaded patch set 3 10/31/22, 11:02

  2. core-ci voted on patch set 3 V +1 10/31/22, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32934

  3. Oliver Hader commented on patch set 3 10/31/22, 12:07

    Hm, I fail to see the connection here... did you actually mean `configurePlugin`? (`$pluginType` is resolved from `TYPO3_CONF_VARS` in `registerPlugin`)

    Important-98960-DefaultTypeDefinitionOfCustomContentTypes.rst:16

    `configurePlugin` and it's the 5th parameter
  4. Benni Mack uploaded patch set 4 10/31/22, 12:33

  5. core-ci voted on patch set 4 V +1 10/31/22, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32935

  6. Benni Mack uploaded patch set 5 10/31/22, 12:42

  7. core-ci voted on patch set 5 V +1 10/31/22, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32936

  8. Georg Ringer voted on patch set 5 CR +1 10/31/22, 12:56

  9. Benni Mack commented on patch set 5 10/31/22, 12:56

    Important-98960-DefaultTypeDefinitionOfCustomContentTypes.rst:16 Reply

    Done
  10. Nikita Hovratov voted on patch set 5 V +1 CR +1 10/31/22, 15:38

  11. Stefan Bürk voted on patch set 5 V +1 CR +1 10/31/22, 15:46

  12. Georg Ringer commented on patch set 5 CR -1 11/02/22, 06:13

    Important-98960-DefaultTypeDefinitionOfCustomContentTypes.rst:45

    the return value is a new feature of v12, how to handle that in a 11.5.x rst?!
  13. Stefan Bürk commented on patch set 5 V 0 CR 0 11/02/22, 08:16

    Important-98960-DefaultTypeDefinitionOfCustomContentTypes.rst:45 Reply

    You are right, good catch ... would say the classic way, setting the variable manually before/after and leaving the return type out: ``` //$contentTypeName = strtolower($extensionName) . '_' . strtolower($pluginName); $contentTypeName = strtolower('Felogin') . '_' . strtolower('Login'); ```
  14. Nikita Hovratov voted on patch set 5 V 0 CR 0 11/02/22, 08:23

  15. Georg Ringer commented on patch set 5 11/02/22, 08:37

    Important-98960-DefaultTypeDefinitionOfCustomContentTypes.rst:45 Reply

    or we backport the other change as well, would love that feature for the same reason ;) or we differentiate in the RST which would be ok as well. just a strtolower is not the solution as IMO underscores in pluginName are removed
  16. Benni Mack commented on patch set 6 11/04/22, 09:53

    Published edit on patch set 5.
  17. Benni Mack commented on patch set 6 11/04/22, 09:53

    Important-98960-DefaultTypeDefinitionOfCustomContentTypes.rst:45 Reply

    changed the comment for now to continue here for v11.5.
  18. core-ci voted on patch set 6 V +1 11/04/22, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33096

  19. Oli Bartsch commented on patch set 6 11/04/22, 16:20

    ExtensionManagementUtility.php:1012

    This might not work in case extensions unset this type.

    Important-98960-DefaultTypeDefinitionOfCustomContentTypes.rst:61

    'showitem'
  20. Benni Mack commented on patch set 7 11/05/22, 12:00

    Published edit on patch set 6.
  21. Benni Mack commented on patch set 7 11/05/22, 12:00

    ExtensionManagementUtility.php:1012 Reply

    Done

    Important-98960-DefaultTypeDefinitionOfCustomContentTypes.rst:61 Reply

    Done
  22. core-ci voted on patch set 7 V +1 11/05/22, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33144

  23. Georg Ringer voted on patch set 7 V +1 CR +1 11/07/22, 20:51

  24. Oli Bartsch voted on patch set 7 V +2 CR +2 11/07/22, 22:49

  25. Oli Bartsch merged patch set 8 11/07/22, 22:49