Review main Merged

76325[BUGFIX] Ensure proper functional test setup for FileBackendTest

Stefan Bürk CR +2 V +2 Easy +6 −5 updated 10/29/22, 12:01

Commit message

With the patch resolving #98931 and #98734 the FileBackendTest
has been migrated from unit to a functional test, and thus now
operating on real filesystem. Used directory listing does not
ensure proper sorting on all systems and used PHP versions,
thus the used expectation may be vary depending on the system.

This change tightens the test for all systems by ensuring a
deterministic test setup, using correct file identifiers for
mocked value returns.

Adding missing parent tearDown() call is added as a side-change,
to ensure full test stack and avoid eventually side-effects in
the future.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 1