76327[TASK] Replace prophecy in EXT:form ClosureFinisherTest
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 1
Review log 911
-
Torben Hansen uploaded patch set 1 10/29/22, 11:47
-
core-ci voted on patch set 1 V +1 10/29/22, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32887
-
Oliver Klee commented on patch set 1 10/29/22, 11:58
-
Torben Hansen uploaded patch set 2 10/29/22, 12:04
-
Torben Hansen commented on patch set 2 10/29/22, 12:06
ClosureFinisherTest.php:46ReplyIn patchset 2 I renamed "finisherContextProphecy" to "finisherContextMock". However, FinisherContext::getFormRuntime() does not accept any arguments, therefore I removed the argument match. -
Oliver Klee commented on patch set 2 CR +1 10/29/22, 12:10
ClosureFinisherTest.php:46ReplyAck -
core-ci voted on patch set 2 V +1 10/29/22, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32890
-
Nikita Hovratov voted on patch set 2 V +1 CR +1 10/29/22, 12:15
-
Oliver Klee voted on patch set 2 V +1 10/29/22, 12:17
-
Nikita Hovratov voted on patch set 2 V +2 CR +2 10/29/22, 12:27
-
Nikita Hovratov merged patch set 3 10/29/22, 12:27
ClosureFinisherTest.php:46