Review main Merged

76327[TASK] Replace prophecy in EXT:form ClosureFinisherTest

Torben Hansen CR +2 V +2 Easy +4 −8 updated 10/29/22, 12:27

Commit message

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Torben Hansen uploaded patch set 1 10/29/22, 11:47

  2. core-ci voted on patch set 1 V +1 10/29/22, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32887

  3. Oliver Klee commented on patch set 1 10/29/22, 11:58

    ClosureFinisherTest.php:46

    To match the previous code, we'll also need the arguments matcher.
  4. Torben Hansen uploaded patch set 2 10/29/22, 12:04

  5. Torben Hansen commented on patch set 2 10/29/22, 12:06

    ClosureFinisherTest.php:46 Reply

    In patchset 2 I renamed "finisherContextProphecy" to "finisherContextMock". However, FinisherContext::getFormRuntime() does not accept any arguments, therefore I removed the argument match.
  6. Oliver Klee commented on patch set 2 CR +1 10/29/22, 12:10

    ClosureFinisherTest.php:46 Reply

    Ack
  7. core-ci voted on patch set 2 V +1 10/29/22, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32890

  8. Nikita Hovratov voted on patch set 2 V +1 CR +1 10/29/22, 12:15

  9. Oliver Klee voted on patch set 2 V +1 10/29/22, 12:17

  10. Nikita Hovratov voted on patch set 2 V +2 CR +2 10/29/22, 12:27

  11. Nikita Hovratov merged patch set 3 10/29/22, 12:27